Skip to content

Conversation

@hhubert6
Copy link
Contributor

@hhubert6 hhubert6 commented Nov 24, 2025

Designs introduce warning about GC being disabled on Active LiveViews page but I think having it on every page is a good idea. What do you think?

cc @kraleppa @srzeszut

@hhubert6 hhubert6 linked an issue Nov 24, 2025 that may be closed by this pull request
@hhubert6 hhubert6 force-pushed the 826-update-active-liveviews-page branch from 7e83450 to 6925234 Compare November 24, 2025 16:26
@kraleppa
Copy link
Member

Designs introduce warning about GC being disabled on Active LiveViews page but I think having it on every page is a good idea. What do you think?

I think it's a valid point - this warning is pretty universal and quite important, so displaying it on every page should be desired.

@kraleppa
Copy link
Member

Can we make Active LiveViews and Dead LiveViews sections look the same? I mean the upper one does not have a chevron and has its own scroll, and the second one does not have its own scroll (its uses the page scroll)

IMO this UI is quite inconsistent - each section should have a chevron or not, and each section should have its own scroll or overflow should be handled via page scroll.

As far as I remember we decided to add chevrons and limit height of each section

Screenshot 2025-11-25 at 09 58 57

@kraleppa
Copy link
Member

This section seem to be jumping a bit when opened/closed (but it might be only in my mind 😅 )

Also it's missing a cursor pointer and I'm wondering if the title should be more gray when section is closed? 🤔 It's not on the designs and imo it does not make that much sense since the section seem entirely inactive, but the counter still changes...

Screen.Recording.2025-11-25.at.10.17.45.mov

@srzeszut
Copy link
Contributor

Designs introduce warning about GC being disabled on Active LiveViews page but I think having it on every page is a good idea. What do you think?

Good idea! Adding it on every page makes sense. You might consider using smaller version of the warning on the other pages.

@hhubert6
Copy link
Contributor Author

hhubert6 commented Nov 26, 2025

I've made it look like in designs but IMO the layout is not perfect so I've tried to improve it a little bit but making both sections take maximum space when opened and minimal when closed. I think it's the best approach when keeping everything on the screen and it leaves no empty space. A user can choose between seeing one of the sections on whole page or have it split in two.

Nagranie.z.ekranu.2025-11-26.o.15.13.11.mov

I left Dead LiveViews section open state as a setting but it can be changed alongside with #860

Good idea! Adding it on every page makes sense. You might consider using smaller version of the warning on the other pages.

I think this info is as important all over the LiveDebugger and should stay the same on every page if possible.

cc @kraleppa @srzeszut

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that <3

@hhubert6 hhubert6 merged commit df88cc1 into main Nov 28, 2025
2 of 4 checks passed
@hhubert6 hhubert6 deleted the 826-update-active-liveviews-page branch November 28, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Active LiveViews page

4 participants