Skip to content

Conversation

@srzeszut
Copy link
Contributor

No description provided.

@srzeszut srzeszut linked an issue Nov 24, 2025 that may be closed by this pull request
@srzeszut srzeszut marked this pull request as ready for review November 25, 2025 15:59
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar broke a little. Close button is weirdly placed and report issue footer is too big.

Image Image

Also content of the page in Node Inspector should have max-width but it takes full width.

Image

It's not directly concern of this pr but on Resources page on smaller screen widths sidebar button is displayed but there's no sidebar on this page. Also clicking it gives error in the console. As you already refactor navigation in this pr you can remove it too.

@kraleppa
Copy link
Member

kraleppa commented Nov 27, 2025

Very nice, but I found some UI nitpicks:

  1. This gaps should be the same
Screenshot 2025-11-27 at 11 08 55
  1. Selected tab should be not only underlined, but also its color should change to swm blue

  2. Not selected tabs have incorrect color

  3. Tabs are jumping a bit when changing
    https://github.com/user-attachments/assets/fda7b740-2138-451c-b126-7d111ed21bd7

  4. Add click-away to dropdown in mobile version of navigation bar

  5. This copy button should be just next to the module name with some small gap (like gap-4)

Screenshot 2025-11-27 at 11 16 20
  1. Disconnected state indicator should have the same design as connected state
Screenshot 2025-11-27 at 11 19 12
  1. Apply figma designs to the upper section in node inspector
Screenshot 2025-11-27 at 11 31 02

@srzeszut srzeszut force-pushed the 827-update-layout-of-livedebugger branch from fdc5641 to ab9ecf9 Compare November 28, 2025 14:50
@srzeszut srzeszut requested a review from hhubert6 December 1, 2025 09:39
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@srzeszut srzeszut merged commit 46ce84a into main Dec 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update layout of LiveDebugger

4 participants