-
Notifications
You must be signed in to change notification settings - Fork 19
Refactor: Update layout of LiveDebugger #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidebar broke a little. Close button is weirdly placed and report issue footer is too big.
Also content of the page in Node Inspector should have max-width but it takes full width.
It's not directly concern of this pr but on Resources page on smaller screen widths sidebar button is displayed but there's no sidebar on this page. Also clicking it gives error in the console. As you already refactor navigation in this pr you can remove it too.
lib/live_debugger/app/debugger/web/components/navigation_menu.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger/app/debugger/callback_tracing/web/global_traces_live.ex
Outdated
Show resolved
Hide resolved
|
Very nice, but I found some UI nitpicks:
|
fdc5641 to
ab9ecf9
Compare
lib/live_debugger/app/debugger/web/hook_components/dead_view_mode.ex
Outdated
Show resolved
Hide resolved
hhubert6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌





No description provided.