Skip to content

Bug: assigns minor UI fixes #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraleppa merged 4 commits into from
Nov 26, 2025
Merged

Bug: assigns minor UI fixes #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5060eb
Separate scrolls for pinned assigns and all assigns
kraleppa Nov 25, 2025
352b058
Long pinned assigns have fixed space size on the left
kraleppa Nov 25, 2025
fcc7729
Made assigns sizes stick to right upper corner even when scrolling
kraleppa Nov 25, 2025
7516e2d
Adjusted section title size for assigns
kraleppa Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lib/live_debugger/app/debugger/node_state/web/components.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do

~H"""
<div id="assigns-section-container" phx-hook="AssignsBodySearchHighlight">
<.section id="assigns" class="h-max overflow-y-hidden" title="Assigns">
<.section id="assigns" class="h-max overflow-y-hidden" title="Assigns" title_class="!min-w-14">
<:right_panel>
<div class="flex gap-2">
<AssignsSearch.render
Expand All @@ -59,16 +59,18 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
class="w-full h-max max-h-full overflow-y-auto"
data-search_phrase={@assigns_search_phrase}
>
<div id="pinned-assigns" class="p-4 border-b border-default-border">
<div id="pinned-assigns" class="p-4 border-b border-default-border overflow-x-auto">
<.pinned_assigns_section
id="pinned-"
term_node={@term_node}
pinned_assigns={@pinned_assigns}
/>
</div>
<div id="all-assigns" class="p-4 relative">
<div id="all-assigns" class="relative">
<.assigns_sizes_section assigns_sizes={@assigns_sizes} id="display-container-size-label" />
<ElixirDisplay.static_term id="assigns-" node={@term_node} selectable_level={1} />
<div class="p-4 overflow-x-auto">
<ElixirDisplay.static_term id="assigns-" node={@term_node} selectable_level={1} />
</div>
</div>
</div>
</.section>
Expand All @@ -80,16 +82,18 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
/>
</:search_bar_slot>
<div id="assigns-display-fullscreen-container" data-search_phrase={@assigns_search_phrase}>
<div class="p-4 border-b border-default-border">
<div class="p-4 border-b border-default-border overflow-x-auto">
<.pinned_assigns_section
id="pinned-fullscreen-"
term_node={@term_node}
pinned_assigns={@pinned_assigns}
/>
</div>
<div class="p-4 relative">
<div class="relative">
<.assigns_sizes_section assigns_sizes={@assigns_sizes} id="display-fullscreen-size-label" />
<ElixirDisplay.static_term id="fullscreen-" node={@term_node} selectable_level={1} />
<div class="p-4 overflow-x-auto">
<ElixirDisplay.static_term id="fullscreen-" node={@term_node} selectable_level={1} />
</div>
</div>
</div>
</.fullscreen>
Expand All @@ -111,7 +115,7 @@ defmodule LiveDebugger.App.Debugger.NodeState.Web.Components do
:if={pinned}
class="flex min-h-4.5 [&>div>button]:hidden hover:[&>div>button]:block"
>
<div class="w-4">
<div class="w-4 shrink-0">
<button
class="text-button-red-content hover:text-button-red-content-hover"
phx-click="unpin-assign"
Expand Down
3 changes: 2 additions & 1 deletion lib/live_debugger/app/web/components.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ defmodule LiveDebugger.App.Web.Components do
attr(:id, :string, required: true)
attr(:title, :string, required: true)
attr(:class, :any, default: nil)
attr(:title_class, :any, default: nil)
attr(:inner_class, :any, default: nil)

slot(:right_panel)
Expand All @@ -304,7 +305,7 @@ defmodule LiveDebugger.App.Web.Components do
>
<div class="pl-4 flex items-center h-12 p-2 border-b border-default-border">
<div class="flex justify-between items-center w-full gap-2">
<div class="font-medium text-sm min-w-26"><%= @title %></div>
<div class={["font-medium text-sm min-w-26" | List.wrap(@title_class)]}><%= @title %></div>
<div class="w-max">
<%= render_slot(@right_panel) %>
</div>
Expand Down