Skip to content

Bug: not displaying error in async jobs for dead LiveView #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhubert6 merged 3 commits into from
Dec 1, 2025
Merged

Bug: not displaying error in async jobs for dead LiveView #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e79885
Not displaying error in case of dead LiveView
kraleppa Nov 27, 2025
d52ca90
Change message on empty list
kraleppa Nov 27, 2025
8617e06
Fix e2e test
hhubert6 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/live_debugger/app/debugger/async_jobs/web/async_jobs_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ defmodule LiveDebugger.App.Debugger.AsyncJobs.Web.AsyncJobsLive do
<%= async_jobs_failed(@async_jobs) %>
</:failed>
<div :if={Enum.empty?(async_jobs)} class="w-full flex items-center justify-center">
<span class=" text-secondary-text">No async jobs found</span>
<span class=" text-secondary-text">No active async jobs found</span>
</div>
<.async_job
:for={async_job <- async_jobs}
Expand Down Expand Up @@ -148,6 +148,12 @@ defmodule LiveDebugger.App.Debugger.AsyncJobs.Web.AsyncJobsLive do
|> noreply()
end

def handle_async(:fetch_async_jobs, {:ok, {:error, :not_alive_or_not_a_liveview}}, socket) do
socket
|> assign(:async_jobs, AsyncResult.ok([]))
|> noreply()
end

def handle_async(:fetch_async_jobs, {:ok, {:error, reason}}, socket) do
socket
|> assign(:async_jobs, AsyncResult.failed(AsyncResult.loading(), reason))
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/async_jobs_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ defmodule LiveDebugger.E2E.AsyncJobsTest do

defp async_job_name(name), do: css("#async-jobs p.font-medium", text: name)

defp no_async_jobs(), do: css("#async-jobs", text: "No async jobs found")
defp no_async_jobs(), do: css("#async-jobs", text: "No active async jobs found")

defp node_module_info(text),
do: css("#node-inspector-basic-info-current-node-module", text: text)
Expand Down