feat: new type proposition #495
Conversation
| export interface AudioOptions extends BaseAudioOptions { | ||
| androidAcceptsDelayedFocusGain?: boolean; | ||
| androidAudioAttributes?: AudioAttributeType; | ||
| androidFocusGain?: focusGainType; |
There was a problem hiding this comment.
can't comment on the original type: we should have only one case-type when it comes to setting options, currently:
- ios settings are camel case
- android settings are snake case
- permission status (which is kind of related) is upper-case
There was a problem hiding this comment.
Also i'm wondering if we should include spatialization behaviour currently, it seems it is either auto or off. I think we could stick with whatever is default for now.
Especially some-day we will have our on spatialization implementation thus we would like to have this off by defULT
There was a problem hiding this comment.
As we talked a bit today about this: could you add short JSDoc-like descriptions to the values (aka what is their meaning). Could be a great start for documenting the api on code-level :)
There was a problem hiding this comment.
with case-type I wanted to stick with original system values, therefore it is different for ios and android, but it can be narrowed to one easily
| * interruptions and emit events accordingly (true by default). | ||
| * @param options - Additional audio options to configure the audio session. | ||
| */ | ||
| setAudioOptions(observeAudioInterruption = true, options?: AudioOptions) { |
There was a problem hiding this comment.
I think we have to call observe interruption every play invocation on Android so merging AudioSession settings into one method its not the best option in my opinion
There was a problem hiding this comment.
so am I correct, if the audio interruption event will be fired, it won't be invoked 2nd time and we have to re-observe it?
Closes #
Introduced changes
Checklist