Skip to content

[Blocked] refactor: updated AVAudioSessionCategoryOptions #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Blocked] refactor: updated AVAudioSessionCategoryOptions #558

wants to merge 3 commits into from
+12 −6

Conversation

vltkv
Copy link
Contributor

@vltkv vltkv commented Jul 11, 2025 •
edited
Loading

Closes RNAA-148

⚠️ Breaking changes ⚠️

  • Removed deprecated AVAudioSessionCategoryOptionAllowBluetooth
  • Added AVAudioSessionCategoryOptionAllowBluetoothHFP and AVAudioSessionCategoryOptionBluetoothHighQualityRecording

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

michalsek
michalsek requested changes Jul 12, 2025
View reviewed changes
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some weird formatting issue in the docpage

@michalsek michalsek changed the title refactor: updated AVAudioSessionCategoryOptions [Blocked] refactor: updated AVAudioSessionCategoryOptions Jul 17, 2025
@vltkv vltkv requested a review from michalsek July 23, 2025 13:36
maciejmakowski2003
maciejmakowski2003 reviewed Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work? have you tested it?

@vltkv
Copy link
Contributor Author

vltkv commented Jul 24, 2025

does it work? have you tested it?

Yes, I've tested it, and it works in the Xcode beta.

@mdydek
Copy link
Contributor

mdydek commented Sep 4, 2025

blocked, because we use something that requires xcode beta for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 left review comments

@michalsek michalsek Awaiting requested review from michalsek

Requested changes must be addressed to merge this pull request.

Assignees

@vltkv vltkv

Labels
breaking-change refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vltkv @mdydek @michalsek @maciejmakowski2003