Feat/recording notification #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
requested changes
Jan 13, 2026
packages/audiodocs/docs/system/recording-notification-manager.mdx
Outdated
Show resolved
Hide resolved
packages/audiodocs/docs/system/recording-notification-manager.mdx
Outdated
Show resolved
Hide resolved
...eact-native-audio-api/android/src/main/java/com/swmansion/audioapi/core/NativeAudioPlayer.kt
Outdated
Show resolved
Hide resolved
...ct-native-audio-api/android/src/main/java/com/swmansion/audioapi/core/NativeAudioRecorder.kt
Outdated
Show resolved
Hide resolved
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Show resolved
Hide resolved
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Show resolved
Hide resolved
packages/react-native-audio-api/src/system/notification/PlaybackNotificationManager.ts
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/system/notification/RecordingNotificationManager.ts
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/web-system/notification/RecordingNotificationManager.ts
Show resolved
Hide resolved
michalsek
requested changes
Jan 13, 2026
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Overall looks good, but lets talk a bit what to do about reverts that not necessarily we would like to be reverted. We can create followup tasks if they are not critical to "revert the revertion" later, for important parts it would be best to bring them back before merge'ing
packages/audiodocs/docs/system/recording-notification-manager.mdx
Outdated
Show resolved
Hide resolved
...eact-native-audio-api/android/src/main/java/com/swmansion/audioapi/core/NativeAudioPlayer.kt
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/src/system/notification/PlaybackNotificationManager.ts
Show resolved
Hide resolved
packages/react-native-audio-api/src/system/notification/RecordingNotificationManager.ts
Outdated
Show resolved
Hide resolved
poneciak57
reviewed
Jan 14, 2026
poneciak57
approved these changes
Jan 14, 2026
Contributor
poneciak57
left a comment
poneciak57
left a comment
There was a problem hiding this comment.
It looks great. But wait before merging.
michalsek
reviewed
Jan 14, 2026
...pi/android/src/main/java/com/swmansion/audioapi/system/notification/RecordingNotification.kt
Show resolved
Hide resolved
maciejmakowski2003
approved these changes
Jan 14, 2026
* fix: reverted recorder notification * feat: android refactor * chore: some leftovers * refactor: ios refactor
…ware-mansion/react-native-audio-api into feat/recording-notification
michalsek
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-397, RNAA-370
Introduced changes
Checklist