feat: add clang-format #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for this. Ideally we would like to merge such PRs in two steps:
Currently it's pretty hard to review it, as there are so many changes in single commit. Hard to see if there are only formatting related changes |
IvanIhnatsiuk
force-pushed
the
feat/clang-format
branch
from
896aaea to
264659f
Compare
kacperzolkiewski
approved these changes
Dec 3, 2025
tomekzaw
reviewed
Dec 4, 2025
Co-authored-by: Tomasz Zawadzki <[email protected]>
exploIF
reviewed
Dec 5, 2025
Collaborator
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
Looks good, one minor comment and we can merge it
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Run clang lint |
Collaborator
There was a problem hiding this comment.
Can we simply add this job a step in lint job in ci workflow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added clang-format to format C++ and Objective-C code
How to test?
Run
yarn lint-clangcommand