Skip to content

Change configuration in LLMModule so it can be set before loading model #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msluszniak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change configuration in LLMModule so it can be set before loading model #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/react-native-executorch/src/modules/natural_language_processing/LLMModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ import {

export class LLMModule {
private controller: LLMController;
private pendingConfig?: {
chatConfig?: Partial<ChatConfig>;
toolsConfig?: ToolsConfig;
generationConfig?: GenerationConfig;
};

constructor({
tokenCallback,
Expand Down Expand Up @@ -39,6 +44,11 @@ export class LLMModule {
...model,
onDownloadProgressCallback,
});

if (this.pendingConfig) {
this.controller.configure(this.pendingConfig);
this.pendingConfig = undefined;
}
}

setTokenCallback({
Expand All @@ -58,7 +68,12 @@ export class LLMModule {
toolsConfig?: ToolsConfig;
generationConfig?: GenerationConfig;
}) {
this.controller.configure({ chatConfig, toolsConfig, generationConfig });
const config = { chatConfig, toolsConfig, generationConfig };
if (this.controller.isReady) {
this.controller.configure(config);
} else {
this.pendingConfig = config;
}
}

async forward(input: string): Promise<string> {
Expand Down
Loading