Skip to content

Cancel failed buttons in reset #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Cancel failed buttons in reset #3350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c52285
Call onReset before clearing view
oblador Jan 21, 2025
83f3a71
Cancel failed buttons on reset
oblador Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/swmansion/gesturehandler/core/GestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,14 +770,14 @@ open class GestureHandler<ConcreteGestureHandlerT : GestureHandler<ConcreteGestu
}
}
fun reset() {
onReset()
view = null
orchestrator = null
Arrays.fill(trackedPointerIDs, -1)
trackedPointersIDsCount = 0
trackedPointersCount = 0
trackedPointers.fill(null)
touchEventType = RNGestureHandlerTouchEvent.EVENT_UNDETERMINED
onReset()
}

fun withMarkedAsInBounds(closure: () -> Unit) {
Expand Down
3 changes: 3 additions & 0 deletions android/src/main/java/com/swmansion/gesturehandler/core/NativeViewGestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ class NativeViewGestureHandler : GestureHandler<NativeViewGestureHandler>() {
}

override fun onReset() {
if (state == STATE_FAILED && view != null) {
onCancel()
}
this.hook = defaultHook
}

Expand Down
Loading