Skip to content

[Monorepo] Add ExpoExample #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 7, 2025
Merged

[Monorepo] Add ExpoExample #3494

merged 25 commits into from
May 7, 2025

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Apr 22, 2025

Description

This PR adds ExpoExample app into our repository. This will replace old example.

Test plan

Test ExpoExample on iOS, android and web

@m-bert m-bert mentioned this pull request Apr 24, 2025
Merged
23 tasks
@m-bert m-bert marked this pull request as ready for review April 29, 2025 14:33
@j-piasecki
Copy link
Member

iOS doesn't build for me:
image

I cloned the repo, checked out the branch, installed node dependencies, npx expo prebuild in the ExpoExample, and built with XCode (16.3). Let me know if I missed something.

@j-piasecki
Copy link
Member

j-piasecki commented Apr 30, 2025 •
edited
Loading

Android works, though that's a new one:

Screen.Recording.2025-04-30.at.08.34.41.mov

No idea which change caused it (monorepo, bumping Expo/RN/Reanimated/Something else, turning on the new arch) but also:

  • Ball with velocity is no longer animated
  • Overlap sometimes crashes
  • New Api -> Chat heads crashes when opened

@m-bert
Copy link
Contributor Author

m-bert commented Apr 30, 2025 •
edited
Loading

Ball with velocity is no longer animated

That's a problem with Reanimated. It has already been fixed and released in 3.17.5, but I haven't bumped version yet 😅

@m-bert
Copy link
Contributor Author

m-bert commented Apr 30, 2025

Also for the failed build on iOS, I've just tried it on my machine and it seems that I forgot to commit newest yarn.lock - in my case it works fine with it (and the outdated one doesn't). Could you please check that?

@m-bert
Copy link
Contributor Author

m-bert commented Apr 30, 2025

Okay, it seems that "Chat head" example was crashing because of safe-area-context (see here), it should be ok now.

@m-bert
Copy link
Contributor Author

m-bert commented Apr 30, 2025

Overlap sometimes crashes

Is it deterministic? I've been playing with it for a bit and I couldn't break it 😅

@j-piasecki
Copy link
Member

Is it deterministic? I've been playing with it for a bit and I couldn't break it 😅

IIRC the message was exactly the same as in the Chat heads, if you were testing after bumping safe-area-context, then it was likely fixed.

j-piasecki
j-piasecki approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both platforms build and the issues I've seen previously are resolved 🪨

Base automatically changed from @mbert/monorepo-migrate-example-apps to @mbert/monorepo May 7, 2025 06:43
@m-bert m-bert merged commit 436c4e1 into @mbert/monorepo May 7, 2025
1 of 2 checks passed
@m-bert m-bert deleted the @mbert/monorepo-add-expo-example branch May 7, 2025 07:13
m-bert added a commit that referenced this pull request May 23, 2025
@m-bert
[Monorepo] Migrate to monorepo (#3482)
4644de7 
## Description

This is base PR that migrates our repository into monorepo structure. It creates following structure:

- `/apps` - here we will put our example apps.
- `/packages` - main directory for Gesture Handler package, along with documentation.
- `/scripts` - scripts that are used by _**GestureHandler**_ (for example formatting scripts)

## Steps

<details>
<summary>Here is the list of PRs that fix issues caused by changing structure of the repository:</summary>

1. #3487
2. #3490
3. #3494
4. #3495
5. #3496
6. #3497
7. #3503
8. #3506
9. #3507
10. #3510
11. #3515
12. #3518
13. #3519
14. #3524
15. #3525
16. #3526
18. #3528

</details>

Note that most of them depends on previous ones, so **_they had to be merged in given order_** (at least up to no. 9).

## Test plan

<details>
<summary>Following subjects were tested in order to make sure that everything works after migration:</summary>

### Example apps

- [x] basic-example
  - [x] Android
  - [x] iOS
- [x] expo-example (fabric)
  - [x] Android
  - [x] iOS
  - [x] web (in that case architecture doesn't matter)
- [x] expo-example (paper)
  - [x] Android
  - [x] iOS
- [x] macos-example

### Scripts

- [x] check-android-dirs
- [x] check-rn-versions
- [x] format-android
- [x] format-apple
- [x] codegen-check-consistency
- [x] codegen-sync-archs
- [x] clangd

### Linters

- [x] prettier
- [x] eslint
- [x] lint-staged

### docs

- [x] check documentation

### Build from generated package

- [x] New app builds correctly

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m-bert @j-piasecki