Skip to content

fix: gesture not activating due to outdated handler tag #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: gesture not activating due to outdated handler tag #3578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6d7d9b
fix: gesture not activating due to outdated handler tag
hannojg Jun 26, 2025
0f86e26
Mark `handlerTag` as `internal`
m-bert Oct 8, 2025
d0e4c1a
Add `handlerTag` on web
m-bert Oct 8, 2025
0015f5b
Merge branch 'main' into fix/gesture-not-activating
m-bert Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../react-native-gesture-handler/src/handlers/gestures/GestureDetector/useAnimatedGesture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
runWorklet(CALLBACK_TYPE.FINALIZE, gesture, event, false);
}
} else if (isTouchEvent(event)) {
if (!stateControllers[i]) {
if (!stateControllers[i] || stateControllers[i].handlerTag !== event.handlerTag) {

Check failure on line 166 in packages/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useAnimatedGesture.ts

View workflow job for this annotation

GitHub Actions / check 

Replace `!stateControllers[i]·||·stateControllers[i].handlerTag·!==·event.handlerTag` with `⏎··········!stateControllers[i]·||⏎··········stateControllers[i].handlerTag·!==·event.handlerTag⏎········`
stateControllers[i] = GestureStateManager.create(event.handlerTag);
}

Expand Down
4 changes: 4 additions & 0 deletions packages/react-native-gesture-handler/src/handlers/gestures/gestureStateManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
activate: () => void;
fail: () => void;
end: () => void;
/** @internal */
handlerTag: number;
}

const warningMessage = tagMessage(
Expand All @@ -21,6 +23,8 @@
function create(handlerTag: number): GestureStateManagerType {
'worklet';
return {
handlerTag,

Check failure on line 27 in packages/react-native-gesture-handler/src/handlers/gestures/gestureStateManager.ts

View workflow job for this annotation

GitHub Actions / check 

Delete `····`
begin: () => {
'worklet';
if (REANIMATED_AVAILABLE) {
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/src/handlers/gestures/gestureStateManager.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
export const GestureStateManager = {
create(handlerTag: number): GestureStateManagerType {
return {
handlerTag,

Check failure on line 8 in packages/react-native-gesture-handler/src/handlers/gestures/gestureStateManager.web.ts

View workflow job for this annotation

GitHub Actions / check 

Delete `······`
begin: () => {
NodeManager.getHandler(handlerTag).begin();
},
Expand Down
Loading