Remove paper support #3639
Remove paper support #3639
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Beautiful ❤️ |
|
I think this should be targeting the |
latekvo
force-pushed
the
@latekvo/remove-paper-support-new
branch
from
da63110 to
31a9fdd
Compare
latekvo
force-pushed
the
@latekvo/remove-paper-support-new
branch
from
31a9fdd to
4730f8a
Compare
…m/software-mansion/react-native-gesture-handler into @latekvo/remove-paper-support-new
| def isNewArchitectureEnabled() { | ||
| // This is a workaround for linter crashing when applying the `com.facebook.react` plugin. | ||
| return project.hasProperty("newArchEnabled") && project.newArchEnabled == "true" | ||
| } | ||
|
|
There was a problem hiding this comment.
Unfortunately, I couldn't find any proper solution for the linter CI crashing, other than keeping this function in place.
There was a problem hiding this comment.
Just a thought, but what do you think about throwing error if new architecture is not enabled?
There was a problem hiding this comment.
I think we could have some environment variable for the CI to set when it wants to exclude the react plugin from the gradle build file.
what do you think about throwing error
Not sure if that's necessary, I think React Native already throws a warning when new arch is set to false on the versions where it can't be disabled.
packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
Outdated
Show resolved
Hide resolved
| def isNewArchitectureEnabled() { | ||
| // This is a workaround for linter crashing when applying the `com.facebook.react` plugin. | ||
| return project.hasProperty("newArchEnabled") && project.newArchEnabled == "true" | ||
| } | ||
|
|
There was a problem hiding this comment.
Just a thought, but what do you think about throwing error if new architecture is not enabled?
## Description #3639 removed support for React Native old architecture. While it removed script for architectures sync, it is still called on commit hook, thus trying to add commit with updated spec fails. ## Test plan Run `git commit`
Description
This PR removes all paper support.
Tested on all platforms, all
basic-example,expo-exampleandmacos-examplebuild and run successfully.Fixme:
yarn lint:androiddoes not work anymoreTest plan
expo-exampleandbasic-exampleapps on:Android,iOSandMacOS