-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove paper support #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
latekvo
wants to merge
32
commits into
next
Choose a base branch
from
@latekvo/remove-paper-support-new
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−755
Open
Remove paper support #3639
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2efa4d5
drop support in android build
latekvo 172a96c
remove android paper dirs
latekvo 847b138
remove paper build cfg usages
latekvo f09e7d4
flatten split files
latekvo b4a1628
force fabric on expo example
latekvo 4b58d06
remove non-existant android files from package
latekvo 8883496
remove paper CIs
latekvo 4298e09
remove paper check from iOS build config
latekvo 0acfea0
remove all obj-c old arch macros
latekvo 46dfef2
revert package reassignment
latekvo 0c81d9a
remove old arch scripts
latekvo 4730f8a
remove script entries from package.json
latekvo 42f3b8f
revert import ordering change
latekvo 95036c3
remove unused file from pkg
latekvo 90fa341
(amend) remove unused file from pkg
latekvo ab204e3
fix android build crash
latekvo 5204369
fix macos build crash
latekvo ec3f17d
update Podfile.lock file
latekvo 1502684
simplify macos macro
latekvo b396263
remove unused method
latekvo dc2d57b
Merge branch 'next' into @latekvo/remove-paper-support-new
latekvo 8422097
workaround for linter crashing
latekvo b0893d3
Merge branch '@latekvo/remove-paper-support-new' of https://github.co…
latekvo 0c29eb2
fix linting error
latekvo db2c927
fix macos build crash
latekvo a853c6b
remove unused gradle var
latekvo a257641
use universal view instead of splitting
latekvo 0a0c051
add RNGHWindow type
latekvo 5d8fac5
add RNGHScrollView type
latekvo 8c80d3d
force use install_modules_dependencies
latekvo 2b8cc97
Merge branch 'next' into @latekvo/remove-paper-support-new
latekvo 632cb0f
fix extra comma
latekvo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 0 additions & 60 deletions
60
.../src/main/java/com/facebook/react/viewmanagers/RNGestureHandlerButtonManagerDelegate.java
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
...src/main/java/com/facebook/react/viewmanagers/RNGestureHandlerButtonManagerInterface.java
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
...rc/main/java/com/facebook/react/viewmanagers/RNGestureHandlerRootViewManagerDelegate.java
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
...c/main/java/com/facebook/react/viewmanagers/RNGestureHandlerRootViewManagerInterface.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I couldn't find any proper solution for the linter CI crashing, other than keeping this function in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought, but what do you think about throwing error if new architecture is not enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could have some environment variable for the CI to set when it wants to exclude the react plugin from the gradle build file.
Not sure if that's necessary, I think React Native already throws a warning when new arch is set to false on the versions where it can't be disabled.