Fix native gesture reattach

[akwasniewski]

Description

In NativeDetector native gesture failed to reattach when child changed.

Test plan

Add a logging message in attach/detach in android/.../react/RNGestureHandlerRegistry.kt and apple/RNGestureHandlerRegistry.m
`

import * as React from 'react';
import { StyleSheet, Text, View, ScrollView, Button } from 'react-native';
import {
  GestureHandlerRootView,
  NativeDetector,
  useGesture,
} from 'react-native-gesture-handler';

export default function App() {
  const items = Array.from({ length: 5 }, (_, index) => `Item ${index + 1}`);
  const [enabled, setEnabled] = React.useState(true);
  const gesture = useGesture('NativeViewGestureHandler', {
    onBegin: (e) => {
      console.log('onBegin');
    },
    onStart: (e) => {
      console.log('onStart');
    }
  });

  const SV1 = () => (
    <ScrollView style={styles.scrollView1}>
      {items.map((item, index) => (
        <View key={index} style={styles.item}>
          <Text style={styles.text}>{item}</Text>
        </View>
      ))}
    </ScrollView>
  );

  const SV2 = () => (
    <ScrollView style={styles.scrollView2}>
      {items.map((item, index) => (
        <View key={index} style={styles.item}>
          <Text style={styles.text}>{item}</Text>
        </View>
      ))}
    </ScrollView>
  );

  return (
    <GestureHandlerRootView
      style={{ flex: 1, backgroundColor: 'white', paddingTop: 100 }}>
      <Button
        title="Swap the child"
        onPress={() => {
          setEnabled(!enabled);
        }}
      />
      <NativeDetector gesture={gesture}>
        {enabled ? <SV1 /> : <SV2 />}
      </NativeDetector >
    </GestureHandlerRootView >
  );
}

const styles = StyleSheet.create({
  scrollView1: {
    backgroundColor: 'pink',
    marginHorizontal: 20,
  },
  scrollView2: {
    backgroundColor: 'lightblue',
    marginHorizontal: 20,
  },

  item: {
    flexDirection: 'row',
    justifyContent: 'center',
    alignItems: 'center',
    padding: 20,
    margin: 2,
    backgroundColor: 'white',
    borderRadius: 10,
  },
  text: {
    fontSize: 20,
    color: 'black',
  },
});

[m-bert]

I can see that android got a bit "out of sync" with iOS, can we make it so that one is analogous to another?

[m-bert]

Why don't we move this into tryAttachHandlerToChildView?

[akwasniewski]

This is intentional, as tryAttachHandlerToChildView is also used in didAddSubview. attachedNativeHandlers is intentionally not cleaned on reattach, thus there is no need to call addObject again.

[m-bert]

Why was this loop moved outside of tryAttachHandlerToChildView?

Also we could find better name for this method, like tryAttachNativeHandlersToChildView

[akwasniewski]

Done for ios and android.

[m-bert]

Maybe a cosmetic note, but I don't like that we iterate through attachedNativeHandlers and call attachHandlerToView - it looks like we try to attach it again, which is not the case.

[akwasniewski]

I changed the variable name to nativeHandlers