Skip to content
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
68e48c6
Handle shared values on JS
m-bert Aug 5, 2025
bc7c28b
Update config on android
m-bert Aug 5, 2025
e3f51d2
Update config on iOS
m-bert Aug 5, 2025
2df4900
Rename
m-bert Aug 5, 2025
3929618
Change method in ForceTouch
m-bert Aug 6, 2025
ea1f170
Update mocks
m-bert Aug 6, 2025
7cf3962
Rename ID variable
m-bert Aug 6, 2025
dedb725
Remove unnecessary worklet directive
m-bert Aug 6, 2025
03fb873
Merge branch 'next' into @mbert/shared-values
m-bert Aug 7, 2025
26f38b3
Merge branch 'next' into @mbert/shared-values
m-bert Aug 8, 2025
50ffbcd
Inline updateGestureHandler
m-bert Aug 11, 2025
8d1ad9b
Move extracting SharedValues into separate effect
m-bert Aug 11, 2025
9a98e19
Store shared values in array
m-bert Aug 11, 2025
fd6eb79
Rename functions
m-bert Aug 11, 2025
2af12c1
Do not store shared values
m-bert Aug 11, 2025
d8a2824
Merge branch 'next' into @mbert/shared-values
m-bert Aug 11, 2025
4c29715
Merge branch 'next' into @mbert/shared-values
m-bert Aug 11, 2025
dd25163
it works?
akwasniewski Aug 12, 2025
41f615e
proper update
akwasniewski Aug 18, 2025
285c0f5
properly checking bools
akwasniewski Aug 18, 2025
4fd97f8
fix after review
akwasniewski Aug 18, 2025
891df81
fixed too many checks
akwasniewski Aug 18, 2025
fd20c1b
Merge branch 'next' into @mbert/shared-values
m-bert Aug 19, 2025
31a1443
Merge branch '@mbert/shared-values' into @akwasniewski/shared-values-web
akwasniewski Aug 19, 2025
43c2d86
Merge branch 'next' into @mbert/shared-values
m-bert Aug 19, 2025
73bd21b
Use operation block
m-bert Aug 20, 2025
ee63683
Copy config
m-bert Aug 20, 2025
ed5e9d8
Move flushOperations into JS
m-bert Aug 20, 2025
9c89722
Merge branch 'next' into @mbert/shared-values
m-bert Aug 20, 2025
0014899
manually setting config
akwasniewski Aug 20, 2025
c0756a2
manually setting in each handler
akwasniewski Aug 20, 2025
fa62ef8
moved values out of config and added needsPointerData
akwasniewski Aug 20, 2025
a3451ef
restored config update for now
akwasniewski Aug 20, 2025
70f2f00
removed config field
akwasniewski Aug 21, 2025
36bfae5
updating new fields
akwasniewski Aug 21, 2025
8953c34
Merge branch '@mbert/shared-values' into @akwasniewski/shared-values-web
akwasniewski Aug 21, 2025
534e784
Merge branch 'next' into @akwasniewski/shared-values-web
akwasniewski Aug 26, 2025
3d66fb8
merge with next
akwasniewski Aug 26, 2025
2da4640
aligned names
akwasniewski Aug 26, 2025
f490152
removed unncessary checks
akwasniewski Aug 26, 2025
c78bb91
removed redundant check
akwasniewski Aug 26, 2025
847f3ed
simplify
akwasniewski Aug 26, 2025
2fca8a2
Revert "removed redundant check"
akwasniewski Aug 26, 2025
e87ea11
removed bloat setters
akwasniewski Aug 27, 2025
a94436c
Merge branch 'next' into @akwasniewski/shared-values-web
akwasniewski Aug 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
}

// @ts-ignore Types should be HTMLElement or React.Component
NodeManager.getHandler(handlerTag).init(newView, propsRef, actionType);

Check warning on line 66 in packages/react-native-gesture-handler/src/RNGestureHandlerModule.web.ts

View workflow job for this annotation

GitHub Actions / check

Unsafe call of an `any` typed value
},
detachGestureHandler(handlerTag: number) {
if (shouldPreventDrop) {
Expand All @@ -74,15 +74,15 @@
NodeManager.detachGestureHandler(handlerTag);
},
setGestureHandlerConfig(handlerTag: number, newConfig: Config) {
NodeManager.getHandler(handlerTag).updateGestureConfig(newConfig);
NodeManager.getHandler(handlerTag).setGestureConfig(newConfig);

InteractionManager.instance.configureInteractions(
NodeManager.getHandler(handlerTag),
newConfig
);
},
updateGestureHandlerConfig(_handlerTag: number, _newConfig: Config) {
// TODO: To be implemented
updateGestureHandlerConfig(handlerTag: number, newConfig: Config) {
NodeManager.getHandler(handlerTag).updateGestureConfig(newConfig);
},
getGestureHandlerNode(handlerTag: number) {
return NodeManager.getHandler(handlerTag);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,15 @@ export default class FlingGestureHandler extends GestureHandler {
private maxNumberOfPointersSimultaneously = 0;
private keyPointer = NaN;

public override updateGestureConfig({
enabled = true,
...props
}: Config): void {
super.updateGestureConfig({ enabled: enabled, ...props });

if (this.config.direction) {
this.direction = this.config.direction;
public override updateGestureConfig(config: Config): void {
super.updateGestureConfig(config);

if (config.direction) {
this.direction = config.direction;
}

if (this.config.numberOfPointers) {
this.numberOfPointersRequired = this.config.numberOfPointers;
if (config.numberOfPointers) {
this.numberOfPointersRequired = config.numberOfPointers;
}
}

Expand Down
Loading
Loading