Document pinch gesture handler Android fixes and provide comprehensive fix analysis #3680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a comprehensive analysis and documentation of the key pull requests that fix pinch gesture handler issues on Android. After extensive research through the repository's issues and PRs, I've identified the most important fixes that address various Android-specific problems with pinch gestures.
Key Findings
Recently Merged Fixes (2024)
PR #2983 - "Fix of rotation and pinch gesture on android" (July 2024)
PR #3072 - "fix: pinch gesture velocity expressed in scale factor per second on android" (August 2024)
Critical Historical Fixes
PR #1879 - "Add modified
ScaleGestureDetector
from AOSP" (March 2022)mMinSpan
to 0 instead of 27mm, making small pinch gestures work properlyPR #2264 - "Fix missing
begin
event on Android for Pinch and Rotation" (October 2022)NaN
which prevented begin events from firingOutstanding Issue
PR #2370 - "Fixed faulty pinch gesture handler on Android when in a ScrollView/FlatList" (Open since January 2023)
Impact
These fixes collectively address the major Android pinch gesture issues:
ScaleGestureDetector
from AOSP #1879)begin
event on Android for Pinch and Rotation #2264)For developers experiencing pinch gesture issues on Android, the most impactful fix is PR #1879 which fundamentally improves the gesture detection mechanism, while PR #2370 addresses the common ScrollView use case but remains unmerged.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.