-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add missing types #3731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add missing types #3731
Changes from 4 commits
3cb1164
a26c22d
052bfb7
652fe3f
43bd77d
2b291b6
704d604
4b3451d
212bbc2
679ab46
f92baae
762c71c
fb3be0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,7 +168,11 @@ export { NativeDetector } from './v3/NativeDetector/NativeDetector'; | |
export * from './v3/hooks/useGesture'; | ||
export * from './v3/hooks/relations'; | ||
|
||
export { SingleGestureName } from './v3/types'; | ||
export { | ||
SingleGestureName, | ||
SingleGestureType, | ||
ComposedGesture as ComposedGestureType, | ||
|
||
} from './v3/types'; | ||
|
||
export * from './v3/hooks/gestures'; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,34 @@ | ||
export type { TapGestureConfig } from './useTap'; | ||
export { useTap } from './useTap'; | ||
export { useTap, TapGestureType, TapGestureEvent } from './useTap'; | ||
|
||
export type { FlingGestureConfig } from './useFling'; | ||
export { useFling } from './useFling'; | ||
export { useFling, FlingGestureType, FlingGestureEvent } from './useFling'; | ||
|
||
export type { LongPressGestureConfig } from './useLongPress'; | ||
export { useLongPress } from './useLongPress'; | ||
export { | ||
useLongPress, | ||
LongPressGestureType, | ||
LongPressGestureEvent, | ||
} from './useLongPress'; | ||
|
||
export type { PinchGestureConfig } from './usePinch'; | ||
export { usePinch } from './usePinch'; | ||
export { usePinch, PinchGestureType, PinchGestureEvent } from './usePinch'; | ||
|
||
export type { RotationGestureConfig } from './useRotation'; | ||
export { useRotation } from './useRotation'; | ||
export { | ||
useRotation, | ||
RotationGestureType, | ||
RotationGestureEvent, | ||
} from './useRotation'; | ||
|
||
export type { HoverGestureConfig } from './useHover'; | ||
export { useHover } from './useHover'; | ||
export { useHover, HoverGestureType, HoverGestureEvent } from './useHover'; | ||
|
||
export type { ManualGestureConfig } from './useManual'; | ||
export { useManual } from './useManual'; | ||
export { useManual, ManualGestureType, ManualGestureEvent } from './useManual'; | ||
|
||
export type { NativeViewGestureConfig } from './useNative'; | ||
export { useNative } from './useNative'; | ||
export { useNative, NativeGestureType, NativeGestureEvent } from './useNative'; | ||
|
||
export type { PanGestureConfig } from './usePan'; | ||
export { usePan } from './usePan'; | ||
export { usePan, PanGestureType, PanGestureEvent } from './usePan'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,8 @@ export type SingleGesture<THandlerData, TConfig> = { | |
gestureRelations: GestureRelations; | ||
}; | ||
|
||
export type SingleGestureType = SingleGesture<unknown, unknown>; | ||
|
||
|
||
export type ComposedGesture = { | ||
tags: number[]; | ||
type: ComposedGestureName; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SingleGestureName
? I'm preety sure it is no longer needed after we added dedicated gesture hooks, am I correct cc @m-bert? I could remove it in this PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it is no longer required. It was with
useGesture
but now it is only internal (but please make sure that it's true before removing it 😅)