-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add missing types #3731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akwasniewski
wants to merge
13
commits into
next
Choose a base branch
from
@akwasniewski/add-missing-types
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add missing types #3731
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3cb1164
add missing types
akwasniewski a26c22d
Merge branch 'next' into @akwasniewski/add-missing-types
akwasniewski 052bfb7
addded type suffix
akwasniewski 652fe3f
exporting single and composed gesture types
akwasniewski 43bd77d
SingleGestureType as a union
akwasniewski 2b291b6
new api gets better names
akwasniewski 704d604
import, export type
akwasniewski 4b3451d
update types in tests and examples
akwasniewski 212bbc2
Merge branch 'next' into @akwasniewski/add-missing-types
akwasniewski 679ab46
export correct types
akwasniewski f92baae
fix wrong import
akwasniewski 762c71c
more specific export
akwasniewski fb3be0e
even more specific type
akwasniewski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
packages/react-native-gesture-handler/src/v3/hooks/gestures/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,67 @@ | ||
import type { FlingGestureEvent, FlingGesture } from './useFling'; | ||
import type { HoverGestureEvent, HoverGesture } from './useHover'; | ||
import type { LongPressGestureEvent, LongPressGesture } from './useLongPress'; | ||
import type { ManualGestureEvent, ManualGesture } from './useManual'; | ||
import type { NativeGestureEvent, NativeGesture } from './useNative'; | ||
import type { PanGestureEvent, PanGesture } from './usePan'; | ||
import type { PinchGestureEvent, PinchGesture } from './usePinch'; | ||
import type { RotationGestureEvent, RotationGesture } from './useRotation'; | ||
import type { TapGestureEvent, TapGesture } from './useTap'; | ||
|
||
export type { TapGestureConfig } from './useTap'; | ||
export type { TapGesture, TapGestureEvent }; | ||
export { useTap } from './useTap'; | ||
|
||
export type { FlingGestureConfig } from './useFling'; | ||
export type { FlingGesture, FlingGestureEvent }; | ||
export { useFling } from './useFling'; | ||
|
||
export type { LongPressGestureConfig } from './useLongPress'; | ||
export type { LongPressGesture, LongPressGestureEvent }; | ||
export { useLongPress } from './useLongPress'; | ||
|
||
export type { PinchGestureConfig } from './usePinch'; | ||
export type { PinchGesture, PinchGestureEvent }; | ||
export { usePinch } from './usePinch'; | ||
|
||
export type { RotationGestureConfig } from './useRotation'; | ||
export type { RotationGesture, RotationGestureEvent }; | ||
export { useRotation } from './useRotation'; | ||
|
||
export type { HoverGestureConfig } from './useHover'; | ||
export type { HoverGesture, HoverGestureEvent }; | ||
export { useHover } from './useHover'; | ||
|
||
export type { ManualGestureConfig } from './useManual'; | ||
export type { ManualGesture, ManualGestureEvent }; | ||
export { useManual } from './useManual'; | ||
|
||
export type { NativeViewGestureConfig } from './useNative'; | ||
export type { NativeGesture, NativeGestureEvent }; | ||
export { useNative } from './useNative'; | ||
|
||
export type { PanGestureConfig } from './usePan'; | ||
export type { PanGesture, PanGestureEvent }; | ||
export { usePan } from './usePan'; | ||
|
||
export type SingleGesture = | ||
| TapGesture | ||
| FlingGesture | ||
| LongPressGesture | ||
| PinchGesture | ||
| RotationGesture | ||
| HoverGesture | ||
| ManualGesture | ||
| NativeGesture | ||
| PanGesture; | ||
|
||
export type SingleGestureEvent = | ||
| TapGestureEvent | ||
| FlingGestureEvent | ||
| LongPressGestureEvent | ||
| PinchGestureEvent | ||
| RotationGestureEvent | ||
| HoverGestureEvent | ||
| ManualGestureEvent | ||
| NativeGestureEvent | ||
| PanGestureEvent; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually want to combine these? At the end of the day, those events are accessed in different callbacks