Skip to content

[iOS] Fix gestures not ending properly on iOS 26 #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+22 −9
Open

[iOS] Fix gestures not ending properly on iOS 26 #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
046d216
Fix Pan
m-bert Oct 7, 2025
fc179b7
Fix Fling
m-bert Oct 7, 2025
2d5c200
Fix LongPress
m-bert Oct 7, 2025
8d30a08
Fix Tap
m-bert Oct 7, 2025
2573a30
Introduce iOS_VERSION macro
m-bert Oct 8, 2025
4213825
Remove triggerAction from reset
m-bert Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNFlingHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,17 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
_lastPoint = [[[touches allObjects] objectAtIndex:0] locationInView:_gestureHandler.recognizer.view];
[super touchesEnded:touches withEvent:event];
[_gestureHandler.pointerTracker touchesEnded:touches withEvent:event];

[self triggerAction];
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
_lastPoint = [[[touches allObjects] objectAtIndex:0] locationInView:_gestureHandler.recognizer.view];
[super touchesCancelled:touches withEvent:event];
[_gestureHandler.pointerTracker touchesCancelled:touches withEvent:event];

[self triggerAction];
}

- (void)triggerAction
Expand All @@ -69,7 +73,6 @@ - (void)triggerAction

- (void)reset
{
[self triggerAction];
[_gestureHandler.pointerTracker reset];
_hasBegan = NO;
[super reset];
Expand Down
8 changes: 4 additions & 4 deletions packages/react-native-gesture-handler/apple/Handlers/RNLongPressHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,16 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[_gestureHandler.pointerTracker touchesEnded:touches withEvent:event];

[self triggerAction];
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[_gestureHandler.pointerTracker touchesCancelled:touches withEvent:event];

[self triggerAction];
}

#else
Expand Down Expand Up @@ -181,10 +185,6 @@ - (BOOL)shouldCancelGesture

- (void)reset
{
if (self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}

[_gestureHandler.pointerTracker reset];

[super reset];
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native-gesture-handler/apple/Handlers/RNPanHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ - (void)interactionsMoved:(NSSet *)touches withEvent:(UIEvent *)event
// UIGestureRecognizerStateFailed here. Making the behavior explicit.
self.state = (self.state == UIGestureRecognizerStatePossible) ? UIGestureRecognizerStateFailed
: UIGestureRecognizerStateCancelled;

[self triggerAction];
[self reset];
return;
}
Expand Down Expand Up @@ -243,19 +245,22 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[self interactionsEnded:touches withEvent:event];

[self triggerAction];
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[self interactionsCancelled:touches withEvent:event];

[self triggerAction];
}

#endif

- (void)reset
{
[self triggerAction];
[_gestureHandler.pointerTracker reset];
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(activateAfterLongPress) object:nil];
self.enabled = YES;
Expand Down
11 changes: 8 additions & 3 deletions packages/react-native-gesture-handler/apple/Handlers/RNTapHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ - (void)interactionsEnded:(NSSet *)touches withEvent:(UIEvent *)event

if (_numberOfTaps == _tapsSoFar && _maxNumberOfTouches >= _minPointers) {
self.state = UIGestureRecognizerStateEnded;

[self triggerAction];
[self reset];
} else {
[self performSelector:@selector(cancel) withObject:nil afterDelay:_maxDelay];
Expand All @@ -141,6 +143,8 @@ - (void)interactionsCancelled:(NSSet *)touches withEvent:(UIEvent *)event
{
[_gestureHandler.pointerTracker touchesCancelled:touches withEvent:event];
self.state = UIGestureRecognizerStateCancelled;

[self triggerAction];
[self reset];
}

Expand Down Expand Up @@ -200,12 +204,16 @@ - (void)touchesEnded:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesEnded:touches withEvent:event];
[self interactionsEnded:touches withEvent:event];

[self triggerAction];
}

- (void)touchesCancelled:(NSSet<RNGHUITouch *> *)touches withEvent:(UIEvent *)event
{
[super touchesCancelled:touches withEvent:event];
[self interactionsCancelled:touches withEvent:event];

[self triggerAction];
}

#endif
Expand Down Expand Up @@ -243,9 +251,6 @@ - (BOOL)shouldFailUnderCustomCriteria

- (void)reset
{
if (self.state == UIGestureRecognizerStateFailed) {
[self triggerAction];
}
[_gestureHandler.pointerTracker reset];

[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(cancel) object:nil];
Expand Down
Loading