-
-
Notifications
You must be signed in to change notification settings - Fork 1k
V3 pressable #3907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
V3 pressable #3907
Conversation
|
Note that I temporarily reverted the broken changes in the shadow node. Without it, the pressable breaks on both android and ios. This change will be reverted before merge. |
| export type { | ||
| PressableProps, | ||
| PressableStateCallbackType, | ||
| } from './components/Pressable'; | ||
| export { default as Pressable } from './components/Pressable'; | ||
| PressableProps as LegacyPressableProps, | ||
| PressableStateCallbackType as LegacyPressableCallbackType, | ||
| } from './v3/components/Pressable'; | ||
| export { default as LegacyPressable } from './v3/components/Pressable'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the new one should be exported as Legacy (and we probably want to export the legacy one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to remove 'v3' from path yesterday 😅. Fixed in ae6e532
Description
V3 implementation of pressable component
Test plan
Tested on the following example