Skip to content

Remove shouldYield commit option#6876

Merged
tomekzaw merged 1 commit intomainfrom
@tomekzaw/remove-should-yield
Jan 9, 2025
Merged

Remove shouldYield commit option#6876
tomekzaw merged 1 commit intomainfrom
@tomekzaw/remove-should-yield

Conversation

@tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jan 8, 2025

Summary

This PR removes shouldYield commit option that was used in ShadowTree::commit in ReanimatedModuleProxy::performOperations.

The reason for the change is that shouldYield commit option has been removed in RN 0.77 in facebook/react-native#47191.

Test plan

@tomekzaw tomekzaw added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 9b1bccb Jan 9, 2025
18 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/remove-should-yield branch January 9, 2025 06:57
tomekzaw added a commit that referenced this pull request Jan 9, 2025
This PR removes `shouldYield` commit option that was used in
`ShadowTree::commit` in `ReanimatedModuleProxy::performOperations`.

The reason for the change is that `shouldYield` commit option has been
removed in RN 0.77 in
facebook/react-native#47191.
This was referenced Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
## Summary

This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

## Test plan

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tomekzaw added a commit that referenced this pull request Jan 13, 2025
This PR removes `shouldYield` commit option that was used in
`ShadowTree::commit` in `ReanimatedModuleProxy::performOperations`.

The reason for the change is that `shouldYield` commit option has been
removed in RN 0.77 in
facebook/react-native#47191.
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR removes `shouldYield` commit option that was used in
`ShadowTree::commit` in `ReanimatedModuleProxy::performOperations`.

The reason for the change is that `shouldYield` commit option has been
removed in RN 0.77 in
facebook/react-native#47191.

## Test plan
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR removes `shouldYield` commit option that was used in
`ShadowTree::commit` in `ReanimatedModuleProxy::performOperations`.

The reason for the change is that `shouldYield` commit option has been
removed in RN 0.77 in
facebook/react-native#47191.

## Test plan
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
patrycjakalinska pushed a commit that referenced this pull request Mar 12, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
patrycjakalinska pushed a commit that referenced this pull request Mar 13, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
## Summary

This PR removes `shouldYield` commit option that was used in
`ShadowTree::commit` in `ReanimatedModuleProxy::performOperations`.

The reason for the change is that `shouldYield` commit option has been
removed in RN 0.77 in
facebook/react-native#47191.

## Test plan
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* software-mansion#6875
* software-mansion#6876
* software-mansion#6883
* software-mansion#6884

---------

Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants