Skip to content

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Oct 17, 2025

Summary

This PR uses REACT_NATIVE_VERSION_MINOR and ReactNativeVersion::Minor added in facebook/react-native#48813 (available from 0.79) instead of a custom definition REACT_NATIVE_MINOR_VERSION as well as removes the minor version retrieval logic from build scripts on Android and iOS.

Test plan

@tomekzaw
Copy link
Member Author

TODO: fix macOS and tvOS builds


result[:is_reanimated_example_app] = ENV["IS_REANIMATED_EXAMPLE_APP"] != nil
result[:is_tvos_target] = react_native_json['name'] == 'react-native-tvos'
result[:react_native_version] = react_native_json['version']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this part of the filer related to looking for the React Native location?

Copy link
Member Author

@tomekzaw tomekzaw Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes, we still use config[:react_native_version] in validate-react-native-version.js.

@tomekzaw
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants