Skip to content

Fix synchronous props updates on iOS below RN 0.81 #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2025
Merged

Fix synchronous props updates on iOS below RN 0.81 #8427

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f73f8d9
Fix synchronous props updates on iOS below RN 0.81
tomekzaw Oct 20, 2025
b9d4ab3
Format files
tomekzaw Oct 20, 2025
215738f
Fix tvOS build by using `REACT_NATIVE_MINOR_VERSION` macro
tomekzaw Oct 21, 2025
c5ba846
Use namespace `facebook::react`
tomekzaw Oct 21, 2025
3a73ba9
Fix implicit conversion
tomekzaw Oct 21, 2025
312c1ab
Remove unused import
tomekzaw Oct 21, 2025
13aa4f8
Format files
tomekzaw Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/react-native-reanimated/apple/reanimated/apple/REANodesManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
#import <React/RCTMountingManager.h>
#import <React/RCTUtils.h>

#if REACT_NATIVE_MINOR_VERSION < 81
#import <React/RCTFollyConvert.h>
#endif

using namespace facebook::react;

@implementation REANodesManager {
READisplayLink *_displayLink;
NSMutableArray<REAOnAnimationCallback> *_onAnimationCallbacks;
Expand Down Expand Up @@ -157,19 +163,22 @@ - (void)maybeFlushUIUpdatesQueue

- (void)synchronouslyUpdateUIProps:(ReactTag)viewTag props:(const folly::dynamic &)props
{
#if !TARGET_OS_OSX
RCTAssertMainQueue();

RCTSurfacePresenter *surfacePresenter = self.surfacePresenter;
RCTComponentViewRegistry *componentViewRegistry = surfacePresenter.mountingManager.componentViewRegistry;
UIView<RCTComponentViewProtocol> *componentView = [componentViewRegistry findComponentViewWithTag:viewTag];
REAUIView<RCTComponentViewProtocol> *componentView =
[componentViewRegistry findComponentViewWithTag:static_cast<Tag>(viewTag)];
NSSet<NSString *> *propKeysManagedByAnimated = [componentView propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN];
#if REACT_NATIVE_MINOR_VERSION >= 81
[surfacePresenter schedulerDidSynchronouslyUpdateViewOnUIThread:viewTag props:props];
#else
[surfacePresenter synchronouslyUpdateViewOnUIThread:@(viewTag) props:convertFollyDynamicToId(props)];
#endif
[componentView setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:propKeysManagedByAnimated];
// `synchronouslyUpdateViewOnUIThread` does not flush props like `backgroundColor` etc.
// so that's why we need to call `finalizeUpdates` here.
[componentView finalizeUpdates:RNComponentViewUpdateMask{}];
#endif // !TARGET_OS_OSX
}

@end
Loading