Add clang tidy performance checks #8429
Draft
+178
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
reviewed
Oct 20, 2025
Comment on lines
35
to
+36
| RegistryEntry{ | ||
| std::move(animationsVector), | ||
| buildAnimationToIndexMap(animationsVector)}); | ||
| animationsVector, buildAnimationToIndexMap(animationsVector)}); |
There was a problem hiding this comment.
I think that we should keep std::move here and just remove the const modifier from the animationsVector declaration:
const auto animationsVector =
buildAnimationsVector(rt, shadowNode, animationNames, newAnimations);This std::move call was added purposely but the the const modifier near the animationsVector prevented it from working as expected.
There was a problem hiding this comment.
What I don't get here is why do we move the animationsVector first and then try to use it straight away. Isn't it in indeterminate state after that?
Comment on lines
6
to
7
| DelayedItem<TValue>::DelayedItem(const double timestamp, const TValue value) | ||
| : timestamp(timestamp), value(value) {} | ||
| : timestamp(timestamp), value(std::move(value)) {} |
There was a problem hiding this comment.
Suggested change
| DelayedItem<TValue>::DelayedItem(const double timestamp, const TValue value) | |
| : timestamp(timestamp), value(value) {} | |
| : timestamp(timestamp), value(std::move(value)) {} | |
| DelayedItem<TValue>::DelayedItem(const double timestamp, TValue value) | |
| : timestamp(timestamp), value(std::move(value)) {} |
Good change. I think you also should remove const from the value parameter declaration.
There was a problem hiding this comment.
Done. I changed timestamp to not-const as well because that's how it's declared in .h.
…comply with the .h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I uncommented
- performance-*clang-tidy check glob. This check encourages good performance practices. After that I solved CSA errors generated by the code.