Open
Conversation
wisniewskij
force-pushed
the
@wisniewskij/css-gradients-anim
branch
from
0c28942 to
a026fda
Compare
wisniewskij
commented
Jan 28, 2026
packages/react-native-reanimated/Common/cpp/reanimated/CSS/InterpolatorRegistry.cpp
Outdated
Show resolved
Hide resolved
wisniewskij
commented
Jan 28, 2026
packages/react-native-reanimated/Common/cpp/reanimated/CSS/InterpolatorRegistry.cpp
Show resolved
Hide resolved
wisniewskij
force-pushed
the
@wisniewskij/css-gradients-anim
branch
from
309593b to
e51c734
Compare
wisniewskij
commented
Jan 30, 2026
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Outdated
Show resolved
Hide resolved
MatiPl01
reviewed
Feb 9, 2026
packages/react-native-reanimated/Common/cpp/reanimated/CSS/InterpolatorRegistry.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/src/css/svg/native/processors/__tests__/stops.test.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/css/svg/native/processors/stops.ts
Outdated
Show resolved
Hide resolved
...ommon-app/src/apps/css/examples/animations/screens/animatedProperties/svg/RadialGradient.tsx
Outdated
Show resolved
Hide resolved
MatiPl01
reviewed
Feb 9, 2026
wisniewskij
force-pushed
the
@wisniewskij/css-gradients-anim
branch
from
16c0a2a to
d645f05
Compare
wisniewskij
changed the base branch from
main
to
@wisniewskij/process-percentage
wisniewskij
force-pushed
the
@wisniewskij/css-gradients-anim
branch
from
9db81a7 to
90df7f2
Compare
MatiPl01
reviewed
Feb 11, 2026
Member
MatiPl01
left a comment
MatiPl01
left a comment
There was a problem hiding this comment.
Good job overall! I left some suggestions and questions. Please refer to them and re-request a review once you finish.
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGStops.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/css/svg/native/processors/__tests__/stops.test.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/css/svg/native/processors/__tests__/stops.test.ts
Show resolved
Hide resolved
wisniewskij
force-pushed
the
@wisniewskij/css-gradients-anim
branch
from
c0009f4 to
875d61b
Compare
MatiPl01
reviewed
Feb 11, 2026
Comment on lines
+33
to
+35
| for (size_t i = 0; i < value.size(); i += 2) { | ||
| double offset = value[i].asDouble(); | ||
| stops.emplace_back(offset, SVGBrush(value[i + 1])); |
Member
There was a problem hiding this comment.
you changed it to pass values as a 1-dimension vector of numbers where offsets are at 2n indices whilst colors are at 2n + 1? I think the previous approach with offset and color properties was much cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR adds SVG RadialGradient CSS Property which enables animation of SVG Radial Gradients.
Test plan
You can play with prepared examples:
Run fabric-example -> CSS -> Animated Properties -> SVG Properties -> RadialGradient