Open
Conversation
Yarn had changed where some dependencies are located - i.e. `react-native` is no longer in the root - so I had to modify the repo setup slightly. - [x] Fabric Example works - [x] MacOS Example works - [x] TVOS Example works - [x] Web Example works - [x] Next Example works - [x] All CI pass
This PR bumps RN version from `0.83` to `0.84.0-rc.2` in fabric and web examples. --------- Co-authored-by: Tomasz Żelawski <[email protected]>
I'm adding `react-native`, its packages and `react` to monorepo root deps. This will fix the problem when `react-native` sometimes gets hoisted to the root of the monorepo and sometimes it doesn't. It fixes currently crashing `fabric-example` on Android after bumping RN to 0.84-rc.2. I also fixed some deps issues in `web-example`. Fabric example and Web example work now.
🚀 Fabric example works 👍
Now RN is hoisted in the root of the monorepo and `hermesc` is no longer in `react-native/sdks`. in `/apps/fabric-example/android` run `./gradlew assembleRelease`.
Meta has just released RN `0.84` stable so we have to update the compatibility and bump deps in example apps.
#8862) ## Summary We should always try to test Worklets Babel plugin in a minimalist environment, without unnecessary presets unless they are necessary. ## Test plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines multiple PRs from the
mainbranch which updated RN versioning in example apps: