cherry-pick(Reanimated): Stop passing nativeID to component in jest unit tests#8954
Open
MatiPl01 wants to merge 1 commit into4.2-stablefrom
Open
cherry-pick(Reanimated): Stop passing nativeID to component in jest unit tests#8954MatiPl01 wants to merge 1 commit into4.2-stablefrom
MatiPl01 wants to merge 1 commit into4.2-stablefrom
Conversation
## Summary
This PR fixes a regression between Reanimated `v4` and `v3`. In `v3`,
there was the following conditional assignment of the `nativeID`:
```tsx
const nativeID =
skipEntering || !isFabric() ? undefined : `${this.reanimatedID}`
```
Since the `isFabric()` always returns `false`, `nativeID` is always
`undefined`, so the `nativeID` was never passed to the component in jest
unit tests.
In the `v4` we removed the `isFabric()` check, so the `nativeID` started
being passed the value of the `this.reanimatedID` property in jest unit
tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the #8881