cherry-pick(Reanimated): remove assert in AnimatedSensorModule destructor#8957
Open
MatiPl01 wants to merge 1 commit into4.2-stablefrom
Open
cherry-pick(Reanimated): remove assert in AnimatedSensorModule destructor#8957MatiPl01 wants to merge 1 commit into4.2-stablefrom
MatiPl01 wants to merge 1 commit into4.2-stablefrom
Conversation
## Summary This PR removes `sensorsIds_.empty()` assert in `~AnimatedSensorModule()` along with the (now empty) destructor itself which was supposedly causing a crash when the app is suspended and moved to the background on iOS. > If you move the app to the background, iOS suspends it, and after some time, if you reopen it, the constructor will be called again as the app resumes. However, the `sensorsIds_` variable is not empty at this point, so the assert will cause the app to crash. There are methods that will clear the `sensorsIds_` upon unmounting, so this assert is essentially causing unnecessary issues. ## Test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the #8823