feat: Add support for compound registry keys in css#8969
Draft
wisniewskij wants to merge 2 commits intomainfrom
Draft
feat: Add support for compound registry keys in css#8969wisniewskij wants to merge 2 commits intomainfrom
wisniewskij wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
|
I believe more tests should be added but I don't really know where to put them. Suggestions are welcome :> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently props builders in CSS are selected based on componentName of the element, which is problematic since there are cases where two different props builders can be needed for two elements with identical componentNames but different componentChildNames (e.g. RNSVG polyline is just RSVGPath underneath). This PR fixes that by adding support for creation of compound keys (componentName + delimiter + componentChildName). This works as a "specialization" mechanism for the registry keys -- if the componentChildName isn't provided or there is no props builder for componentName + delimiter + componentChildName key, then the behavior defaults to the old one (componentName used as a key).
Test plan
I introduced some jest tests.