Skip to content

Commit d8a04d2

Browse files
committed
Change logged tags, remove unnecessary code
1 parent 425972c commit d8a04d2

File tree

5 files changed

+6
-15
lines changed

5 files changed

+6
-15
lines changed

ios/gamma/stack/host/RNSStackHostComponentView.mm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ - (void)initState
4343

4444
- (void)didMoveToWindow
4545
{
46-
RNSLog(@"[RNScreens] StackHost [%pv] attached to window", self);
46+
RNSLog(@"[RNScreens] StackHost [%ld] attached to window", self.tag);
4747
[self reactAddControllerToClosestParent:_stackNavigationController];
4848
}
4949

@@ -119,8 +119,8 @@ - (void)addPopOperationIfNeeded:(nonnull RNSStackScreenComponentView *)stackScre
119119
// This shouldn't happen in typical scenarios but it can happen with fast-refresh.
120120
[_stackOperationCoordinator addPopOperation:stackScreen];
121121
} else {
122-
RNSLog(@"[RNScreens] ignoring pop operation of %s, already not attached or natively dismissed",
123-
[stackScreen.screenKey cStringUsingEncoding:NSUTF8StringEncoding]);
122+
RNSLog(@"[RNScreens] ignoring pop operation of %@, already not attached or natively dismissed",
123+
stackScreen.screenKey);
124124
}
125125
}
126126

ios/gamma/stack/host/RNSStackNavigationController.mm

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,9 @@ - (void)performContainerUpdateIfNeeded
7171

7272
- (void)dumpStackModel
7373
{
74-
RNSLog(@"[RNScreens] StackContainer [%pv] MODEL BEGIN", self);
74+
RNSLog(@"[RNScreens] StackContainer [%ld] MODEL BEGIN", self.view.tag);
7575
for (UIViewController *viewController in self.viewControllers) {
76-
RNSLog(
77-
@"[RNScreens] %s",
78-
[static_cast<RNSStackScreenComponentView *>(viewController.view).screenKey
79-
cStringUsingEncoding:NSUTF8StringEncoding]);
76+
RNSLog(@"[RNScreens] %@", static_cast<RNSStackScreenComponentView *>(viewController.view).screenKey);
8077
}
8178
}
8279

ios/gamma/stack/screen/RNSStackScreenComponentView.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ - (void)initState
4444
_reactEventEmitter = [RNSStackScreenComponentEventEmitter new];
4545

4646
_hasUpdatedActivityMode = NO;
47-
self.isNativelyDismissed = NO;
47+
_isNativelyDismissed = NO;
4848
}
4949

5050
- (void)resetProps

ios/gamma/stack/screen/RNSStackScreenController.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
NS_ASSUME_NONNULL_BEGIN
66

77
@class RNSStackScreenComponentView;
8-
@class RNSStackController;
98

109
@interface RNSStackScreenController : UIViewController
1110

ios/gamma/stack/screen/RNSStackScreenController.mm

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ - (instancetype)initWithComponentView:(RNSStackScreenComponentView *)componentVi
1717
return self;
1818
}
1919

20-
- (instancetype)initWithCoder:(NSCoder *)aDecoder
21-
{
22-
return nil;
23-
}
24-
2520
- (RNSStackScreenComponentEventEmitter *)reactEventEmitter
2621
{
2722
return [_screenView reactEventEmitter];

0 commit comments

Comments
 (0)