fix(Android): prevent crash when we can not insert any subviews into child #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
Contributor
|
I can confirm that this PR fixed the crash with NestedHorizontalScrollViews |
2 tasks
kkafar
added a commit
that referenced
this pull request
Jan 16, 2025
## Description This PR removes the workaround introduced in series of PRs (listed chronologically here): 1. #2307 2. #2383 3. #2495 4. #2531 For detailed description of error mechanism and broader discussion please refer to: 1. [my comment on #2495](#2495 (comment)), 2. [my fix to RN core](facebook/react-native#47634) tldr: When popping screen on Fabric we marked the views as "transitioning" and this led to view being effectively miscounted during removal by view groups that supported react-native's subview clipping mechanism. The issue has been present most likely in every version of the library when running on Android & Fabric, but it arose few months ago due to broader adoption of the new architecture. facebook/react-native#47634 is supposed to fix the underlying issue in `react-native's` core. ## Changes Removed the workaround code from `Screen` implementation on Android. The * facebook/react-native#47634 has been released with 0.77.0-rc.3 and followup small fixup: * facebook/react-native#48329 has been released with 0.77.0-rc.4. Therefore, with landing this PR we should limit our support on Fabric to 0.77.0. ## Test code and steps to reproduce `Test2282` - note that there are few testing variants available there, you just need to comment (out) some parts of the code. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to patch changes from #2495. It improved the situation in most of the cases
but caused crashes in cases where we tried to insert subviews into viewgroups that have any kind of assertions on their child count, e.g.
NestedScrollVieworViewPager.Fixes #2529
Supersedes #2527
Changes
In this PR I do two things:
Test code and steps to reproduce
Test2282 works in both configurations (complex screen with nested flatlists + my simple reproduction of the issue)
Checklist