Skip to content

Conversation

@kkafar
Copy link
Member

@kkafar kkafar commented Dec 11, 2024

Description

WIP WIP PoC stage

While suggested approach with requesting parent layout should work reliably, I'm not sure of what's the best way to animate these changes.
This will give staggering look either way when reducing the sheet size, as the content would disappear in single-frame-span.

Increasing the sheet size should work fine with animation.

Changes

Test code and steps to reproduce

Checklist

@thebiltheory
Copy link

@kkafar is this pull-request still relevant? When can it be merged?

@kkafar
Copy link
Member Author

kkafar commented Mar 13, 2025

It is, it'll land when I have a moment to finalise it :/ Can't say what the delivery date is here

@IgorVanian
Copy link

This patch works well. 🔥 Fixes our problem.

@iankberry
Copy link

Hi @kkafar, I was wondering if you were still planning to finalize/merge this PR? Loving form sheets so far - way more natural than the imperative approach taken by most existing bottom sheet libraries.

@GaylordP
Copy link

Hello @kkafar :)

Will this PR be able to be merged soon?

@MarcusOhman91
Copy link

I'm also standing in line hoping for this to be resolved. Not being able to change height of a fitToContents formSheet after its opened is quite a restriction as of now 🫤

@julien9999
Copy link

any update here?

@t0maboro
Copy link
Contributor

the work is continued in this PR: #3484

@t0maboro t0maboro closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants