Skip to content

Conversation

kmichalikk
Copy link
Collaborator

Description

For some time, the example app has been crashing due to old and misconfigured versions of reanimated. This PR updates gesture-handle, reanimated and adds worklets which are now required by reanimated.

Copy link
Contributor

@kligarski kligarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to do the same with Example app (Paper) but AFAIK Reanimated 4 does not support old architecture, so we should try with an older version I guess?

apps/App.tsx Outdated
Comment on lines 4 to 9
import * as Test from './src/tests';
import Example from './Example';

enableFreeze(true);

export default function App() {
// return <Example />;
return <Test.TestBottomTabs />;
return <Example />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually leave commented out import * as Test from './src/tests'; and return <Test.TestBottomTabs />; lines for convenience.

Copy link
Contributor

@t0maboro t0maboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 remember to restore apps/App.tsx

@kmichalikk kmichalikk requested a review from kligarski August 12, 2025 07:56
Copy link
Contributor

@kligarski kligarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just rebase onto main and regenerate lock files, including both example apps' Podfile.locks.

@kmichalikk kmichalikk force-pushed the @kmichalikk/example-app-fixes branch from 53b8cd4 to 283e729 Compare August 12, 2025 10:54
@kmichalikk kmichalikk requested a review from kligarski August 12, 2025 13:01
@kmichalikk kmichalikk force-pushed the @kmichalikk/example-app-fixes branch from 0b63f70 to e39ca30 Compare August 13, 2025 06:12
@kmichalikk kmichalikk force-pushed the @kmichalikk/example-app-fixes branch from e39ca30 to 3cbb14e Compare August 14, 2025 06:19
@kmichalikk kmichalikk merged commit e863135 into main Aug 14, 2025
8 checks passed
@kmichalikk kmichalikk deleted the @kmichalikk/example-app-fixes branch August 14, 2025 06:40
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing I'm concerned with is that e.g. in FabricExample the version of react-native-safe-area-context effectively got downgraded.

Comment on lines +1742 to +1743
- react-native-safe-area-context/common (= 5.4.0)
- react-native-safe-area-context/fabric (= 5.4.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is interesting that the version got downgraded here 🤔

kmichalikk added a commit that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants