-
-
Notifications
You must be signed in to change notification settings - Fork 574
fix(Example): Make Example app build again #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to do the same with Example
app (Paper) but AFAIK Reanimated 4 does not support old architecture, so we should try with an older version I guess?
apps/App.tsx
Outdated
import * as Test from './src/tests'; | ||
import Example from './Example'; | ||
|
||
enableFreeze(true); | ||
|
||
export default function App() { | ||
// return <Example />; | ||
return <Test.TestBottomTabs />; | ||
return <Example />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually leave commented out import * as Test from './src/tests';
and return <Test.TestBottomTabs />;
lines for convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 remember to restore apps/App.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just rebase onto main and regenerate lock files, including both example apps' Podfile.locks.
53b8cd4
to
283e729
Compare
0b63f70
to
e39ca30
Compare
e39ca30
to
3cbb14e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One thing I'm concerned with is that e.g. in FabricExample the version of react-native-safe-area-context
effectively got downgraded.
- react-native-safe-area-context/common (= 5.4.0) | ||
- react-native-safe-area-context/fabric (= 5.4.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is interesting that the version got downgraded here 🤔
## Description Somehow it got downgraded in #3102
Description
For some time, the example app has been crashing due to old and misconfigured versions of reanimated. This PR updates gesture-handle, reanimated and adds worklets which are now required by reanimated.