fix(Android, FormSheet): Add fallback for undefined corner radius #3291
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on a different task, I noticed that on Android API level 28 or below, the FormSheet might not display correctly. The issue was caused by passing a negative corner radius value when it was
undefinedon the JS side, whichShapeAppearanceModelcould not handle properly. This PR adds a fallback to 0 when the value is not provided.Fixes https://github.com/software-mansion/react-native-screens-labs/issues/480
Changes
sheetCornerRadiuspropScreenshots / GIFs
Before
After
Test code and steps to reproduce
You can open
GlossyFormSheetfromTestFormSheeton Android 28 or lower; I haven't definedsheetCornerRadiusthere.Checklist