Skip to content

refactor(Android, Tabs): Move image loader logic to TabsImageLoader #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

refactor(Android, Tabs): Move image loader logic to TabsImageLoader #3292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5208476
Move image loader logic to TabsImageLoader
t0maboro Oct 10, 2025
1c00b2a
Remove extra callback
t0maboro Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions android/src/main/java/com/swmansion/rnscreens/gamma/tabs/TabScreenViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.swmansion.rnscreens.gamma.tabs

import android.os.Handler
import android.os.Looper
import com.facebook.react.bridge.Dynamic
import com.facebook.react.bridge.ReadableMap
import com.facebook.react.module.annotations.ReactModule
Expand Down Expand Up @@ -194,15 +192,7 @@ class TabScreenViewManager :
) {
val uri = value?.getString("uri")
if (uri != null) {
val context = view.context
loadTabImage(context, uri) { drawable ->
// Since image loading might happen on a background thread
// ref. https://frescolib.org/docs/intro-image-pipeline.html
// We should schedule rendering the result on the UI thread
Handler(Looper.getMainLooper()).post {
view.icon = drawable
}
}
loadTabImage(view.context, uri, view)
}
}

Expand Down
18 changes: 18 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/gamma/tabs/image/TabsImageLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package com.swmansion.rnscreens.gamma.tabs.image

import android.content.Context
import android.graphics.drawable.Drawable
import android.os.Handler
import android.os.Looper
import android.util.Log
import androidx.core.graphics.drawable.toDrawable
import androidx.core.net.toUri
Expand All @@ -13,8 +15,24 @@ import com.facebook.drawee.backends.pipeline.Fresco
import com.facebook.imagepipeline.image.CloseableImage
import com.facebook.imagepipeline.image.CloseableStaticBitmap
import com.facebook.imagepipeline.request.ImageRequestBuilder
import com.swmansion.rnscreens.gamma.tabs.TabScreen

internal fun loadTabImage(
context: Context,
uri: String,
view: TabScreen,
) {
// Since image loading might happen on a background thread
// ref. https://frescolib.org/docs/intro-image-pipeline.html
// We should schedule rendering the result on the UI thread
loadTabImageInternal(context, uri) { drawable ->
Handler(Looper.getMainLooper()).post {
view.icon = drawable
}
}
}

private fun loadTabImageInternal(
context: Context,
uri: String,
onLoaded: (Drawable) -> Unit,
Expand Down
Loading