chore(e2e): maintenance for automated tests after iOS 26.2 #3430
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,7 @@ yarn-error.log | |
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # Yarn | ||
| .yarn/* | ||
| !.yarn/patches | ||
|
|
||
|
Member
There was a problem hiding this comment. I wonder about naming here. What are |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { device, element, by } from 'detox'; | ||
| import { getIOSVersion } from '../../../scripts/e2e/ios-devices.js'; | ||
| import semverSatisfies from 'semver/functions/satisfies'; | ||
| import semverCoerce from 'semver/functions/coerce'; | ||
|
|
||
| const IOS_BAR_BUTTON_TYPE = '_UIButtonBarButton'; | ||
| const backButtonElement = element(by.id('BackButton')); | ||
|
|
||
| export async function tapBarBackButton() { | ||
| const platform = device.getPlatform(); | ||
| if (platform === 'ios') { | ||
| return (await getIOSBackButton()).tap(); | ||
| } else if (platform === 'android') { | ||
| return backButtonElement.tap(); | ||
| } else throw new Error(`Platform "${platform}" not supported`); | ||
| } | ||
| async function getIOSBackButton() { | ||
| const iosVersion = semverCoerce(getIOSVersion().replace('iOS', ''))!; | ||
| if (semverSatisfies(iosVersion, '>=26.0')) { | ||
|
Comment on lines
+18
to
+19
Contributor
There was a problem hiding this comment. I'm wondering if we need
Contributor
Author
There was a problem hiding this comment. I wanted to save some time and several lines of code by adding the dev dependency, but I agree - it is an overkill and we can parse MAJOR.MINOR (or just bare MAJOR) oursevles. I don't have a strong opinion about it.
Member
There was a problem hiding this comment. No, we don't need external dependency for this. Simple helper function is enough for that. Given what is going on with NPM & supply chain attacks recently -> lets avoid any unnecessary dependencies.
Member
There was a problem hiding this comment. Does this function work only on iOS 26+? |
||
| const elementsByAttributes = | ||
| (await backButtonElement.getAttributes()) as unknown as { | ||
| elements: { className: string }[]; | ||
| }; | ||
|
Comment on lines
+21
to
+23
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment. That's the tough one.
Contributor
Author
There was a problem hiding this comment. Oh, I can use magic numbers alternatively (
Contributor
There was a problem hiding this comment. Ok, I see what you mean. I think the current version is all right then. |
||
| const elements = elementsByAttributes.elements; | ||
| if (Array.isArray(elements)) { | ||
| const uiBarButtonIndex = elements.findIndex( | ||
| elem => elem.className === IOS_BAR_BUTTON_TYPE, | ||
| ); | ||
| if (uiBarButtonIndex !== -1) { | ||
| return backButtonElement.atIndex(uiBarButtonIndex); | ||
| } | ||
KrzysztofWojnar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| return backButtonElement; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { getCommandLineResponse } from "react-native-screens/scripts/e2e/command-line-helpers"; | ||
| import { device } from 'detox'; | ||
|
|
||
| export function disableStylusPopupOnAndroid() { | ||
| if (device.getPlatform() === 'ios') return; | ||
| try { | ||
| getCommandLineResponse(`adb -s ${device.id} shell settings put secure stylus_handwriting_enabled 0`); | ||
| } catch { | ||
| console.warn('Failed to disable stylus setting.'); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| { | ||
| "extends": "../tsconfig.json", | ||
| "compilerOptions": { | ||
| "allowJs": true, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question here. Why do we relaunch application instead of reloading RN? This was done mostly to save CI time IIRC, so it is a subject to be changed, but I need reasoning here.