fix(iOS, Stack, Fabric): Pressable hitSlop in header subviews on Fabric
#3446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kligarski
added
Type: Bug
This was referenced Dec 3, 2025
t0maboro
approved these changes
Dec 3, 2025
kkafar
reviewed
Dec 5, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
This looks really good, but I have a question that needs to be answered before we proceed.
Comment on lines
+172
to
182
| // We wrap the headerLeft/Right component in a UIBarButtonItem | ||
| // so we need to hit test subviews, because of the view flattening | ||
| // (we match RCTViewComponentView implementation). | ||
| for (UIView *headerComponentSubview in [subview.subviews reverseObjectEnumerator]) { | ||
| CGPoint convertedPoint = [self convertPoint:point toView:headerComponentSubview]; | ||
| UIView *hitTestResult = [headerComponentSubview hitTest:convertedPoint withEvent:event]; | ||
|
|
||
| if (hitTestResult != nil) { | ||
| headerComponent = hitTestResult; | ||
| return hitTestResult; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The comment above the for loop explicitly states, that the default behaviour of reverse iterating over the children) has been deliberately changed to left to right.
Can we do some research & see what problem exactly this approach solved & whether we do not introduce a regression with swapping this back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Pressable
hitSlopin header subviews on Fabric, iOS.before3446.mov
after3446.mov
Closes https://github.com/software-mansion/react-native-screens-labs/issues/552.
Changes
RNSScreenStack's coordinates to that ofRNSScreenStackHeaderConfig(on Fabric, it has negative origin.y so that ShadowTree knows about navigation bar + subviews positioning)RNSScreenStackHeaderConfig's hitTest:HeaderSubview's subviews and add early return, matchingRCTViewComponentViewimplementationPressableWithFeedbackpass props toPressablecomponentTest code and steps to reproduce
Run
Test3466.Checklist