fix(JS, stack): Fix push fail after 3rd screen in JS stack #3450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kligarski
approved these changes
Dec 4, 2025
Contributor
Author
|
Reported some more issues that are out of scope of this PR: https://github.com/software-mansion/react-native-screens-labs/issues/697 |
t0maboro
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/software-mansion/react-native-screens-labs/issues/583
Description
This PR changes the logic for creating update transactions in
ScreenContainer.onUpdate(). In JS stack, the list of screens on stack is repopulated on each update. Some screens can be set to not detach when covered. By some mysterious logic, we've been adding them to thependingFrontlist and adding them on top. We change this logic so every screen except for the first one are added in the same way.Changes
Modified & refactored logic for reattaching screens in
ScreenContainer.onUpdate().Test code and steps to reproduce
Use Test3450.