chore: Update FormSheet-SAV integration test to cover sheetShouldOverflowTopInset
#3503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update react-navigation & add a prop to the example.
The case with a double top inset in the first video test is acceptable and expected, because all top inset behavior combinations can already be covered using other configuration options.
We can cover all visual scenarios by adjusting the
sheetShouldOverflowTopInsetprop and the use ofSafeAreaViewwith the top edge enabled or disabled:Because these three combinations fully cover all possible variants of top inset behavior, we don't need to treat the double top inset as a bug. It's just one of the valid configurations, and it works correctly depending on how the developer configures their SafeArea usage, combined with Sheet overflow settings.
Fixes: https://github.com/software-mansion/react-native-screens-labs/issues/568
Changes
react-navigationto react-navigation/react-navigation@2b7ee0dTest3336Screenshots / GIFs
Here you can add screenshots / GIFs documenting your change.
You can add before / after section if you're changing some behavior.
demo.mov
Test code and steps to reproduce
Test3336
Note: double inset in the 1st test is
Checklist