Skip to content

Conversation

@t0maboro
Copy link
Contributor

@t0maboro t0maboro commented Dec 22, 2025

Description

Update react-navigation & add a prop to the example.

The case with a double top inset in the first video test is acceptable and expected, because all top inset behavior combinations can already be covered using other configuration options.

We can cover all visual scenarios by adjusting the sheetShouldOverflowTopInset prop and the use of SafeAreaView with the top edge enabled or disabled:

  1. Background and content overflow behind the status bar
  • sheetShouldOverflowTopInset: true
  • SafeAreaView top: disabled
  1. Background overflows, but content respects the SafeArea and avoids the status bar
  • sheetShouldOverflowTopInset: true
  • SafeAreaView top: enabled
  1. Both background and content respect the SafeArea (no overflow)
  • sheetShouldOverflowTopInset: false

Because these three combinations fully cover all possible variants of top inset behavior, we don't need to treat the double top inset as a bug. It's just one of the valid configurations, and it works correctly depending on how the developer configures their SafeArea usage, combined with Sheet overflow settings.

Fixes: https://github.com/software-mansion/react-native-screens-labs/issues/568

Changes

Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

demo.mov

Test code and steps to reproduce

Test3336

Note: double inset in the 1st test is

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@t0maboro t0maboro marked this pull request as ready for review December 22, 2025 08:04
@t0maboro t0maboro changed the title @t0maboro/add sheet should overflow top inset example chore: Update FormSheet-SAV integration test to cover sheetShouldOverflowTopInset Dec 22, 2025
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@t0maboro t0maboro merged commit ecda311 into main Dec 22, 2025
3 checks passed
@t0maboro t0maboro deleted the @t0maboro/add-sheet-should-overflow-top-inset-example branch December 22, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants