-
-
Notifications
You must be signed in to change notification settings - Fork 613
chore: Remove react-native-edge-to-edge from example apps #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove react-native-edge-to-edge from example apps #3520
Conversation
kligarski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just please check that other example test screens work correctly.
t0maboro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we can remove
# This property is supported for RN >= 0.81.
# For RN < 0.81, react-native-edge-to-edge package is necessary.
from Example/android/gradle.properties either
Test2949is usingSystemBarsfromreact-native-edge-to-edgeand it's now crashing with
TurboModuleRegistry.getEnforcing(...): 'RNEdgeToEdge' could not be found.
|
|
ad 2. The test was created because cc @kkafar |
Thanks for the clarification. If only |
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I have few questions for code changes I do not understand. Please answer them.
I'll test the runtime once we're green on the code part.
Example/android/app/src/main/java/com/swmansion/rnscreens/example/MainActivity.kt
Show resolved
Hide resolved
|
Regarding the Test2949 - we're no longer testing our API there. While it in some sense tests our integration with the |
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Closes https://github.com/software-mansion/react-native-screens-labs/issues/355
Changes
This PR removes the
react-native-edge-to-edgedependency form Paper and Fabric example applications in favor of core RN API. For android, the transparent 3-button navigation bar is enabled to match the removed package behavior.setNavigationBarContrastEnforced(false)is called inonAttachedToWindow()for each app's Activity so the navigation bar looks like this (prior to the PR):instead of like this (the default without
react-native-edge-to-edge):Test plan
Run BottomTabsTest, verify that nothing changed in terms of edge-to-edge. Turn on 3-button navigation in Android setttings & verify that its view is transparent / matches the color of tab bar.