feat(Android, Stack v5): nested stack uses childFragmentManager of parent container#3597
Merged
feat(Android, Stack v5): nested stack uses childFragmentManager of parent container#3597
Conversation
`StackScreen` implements now `FragmentProviding` interface. This causes `StackContainer` of nested stack to use `childFragmentManager` of parent container instead of reusing `supportFragmentManager`.
t0maboro
approved these changes
Jan 30, 2026
Contributor
t0maboro
left a comment
t0maboro
left a comment
There was a problem hiding this comment.
it can be merged, when CI is green
Member
Author
|
It's only linter. I'll land it & fix it with follow up PRs @t0maboro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/software-mansion/react-native-screens-labs/issues/921
StackScreenimplements nowFragmentProvidinginterface. This causesStackContainerof nested stack to usechildFragmentManagerof parentcontainer instead of reusing
supportFragmentManager.Changes
N/A
Visual documentation
N/A
Test plan
Not a fix or change in behavior, this is just new behavior.
To verify you need to attach a debugger in
StackContainerand verify that it useschildFragmentManagerof parent container.I've added test example for this use case that I'll likely follow developing in
next PRs.