feat: add new impl for header and toolbar items#3657
Draft
satya164 wants to merge 1 commit intosoftware-mansion:mainfrom
Draft
feat: add new impl for header and toolbar items#3657satya164 wants to merge 1 commit intosoftware-mansion:mainfrom
satya164 wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new component based API and implementation for a unified header and toolbar API. It looks like following:
The `placement: 'header' | 'toolbar' controls where the items are placed.
This is primarily done by Codex, so it needs proper review from someone familiar with iOS.
It also doesn't implement many things currently present in the header items API, and has missing things:
I wasn't able to build the example app in the repo - so didn't manage to test this. Help welcome - I can add an example once I'm able to build.
Changes
package.jsonsrc/barios/barVisual documentation
Code
Test plan
Checklist