Merged
Conversation
sgaczol
requested review from
Copilot,
kkafar,
kligarski,
kmichalikk and
t0maboro
kkafar
reviewed
Mar 3, 2026
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Looks good, thank you!
I've left a single remark
Comment on lines
-46
to
-48
| # Use this property to enable or disable debug logging | ||
| rnsDebugLogsEnabled=true | ||
|
|
Member
There was a problem hiding this comment.
I'd leave this in place, just because it'll be easier to find & modify.
Collaborator
Author
There was a problem hiding this comment.
Can I leave it commented out though so setting it to true/false would be optional then? Leaving it uncommented permanently will disturb default release mode state.
Collaborator
Author
There was a problem hiding this comment.
Nevermind, you're right, it won't interfere there: 1e28b55
t0maboro
approved these changes
Mar 3, 2026
t0maboro
approved these changes
Mar 4, 2026
5 tasks
sgaczol
added a commit
that referenced
this pull request
Mar 5, 2026
## Description This PR changes `RNSLog` activating/deactivating depending on debug/release mode mechanism introduced in #3718 To activate `RNSLog`, set flag `rnsDebugLogsEnabled` to true. ## Changes - update `gradle.properties` in `TVOSExample` - update `build.gradle` ## Before & after - visual documentation N/A ## Test plan Run app with set flag and check if logs work properly. ## Checklist - [ ] Included code example that can be used to test this change. - [ ] Updated / created local changelog entries in relevant test files. - [ ] For visual changes, included screenshots / GIFs / recordings documenting the change. - [ ] For API changes, updated relevant public types. - [ ] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce automatic
RNSLogactivation in debug mode and deactivation in release mode. This behavior can be manually overridden using thernsDebugLogsEnabledflag.Example usage:
yarn run android --mode release --extra-params "-PrnsDebugLogsEnabled=true"activatesRNSLogin release mode.yarn run android --mode debug --extra-params "-PrnsDebugLogsEnabled=false"deactivatesRNSLogin debug mode.Extend
RNSLogfunctionality.Changes
gradle.propertiesandbuild.gradleRNSLoganalogous to native AndroidLogBefore & after - visual documentation
Not applicable.
Test plan
Run app in both modes and check if it works properly.
Checklist