Skip to content

refactor(tests): reorganizing test-tabs-layout-direction plus scenario#3845

Merged
LKuchno merged 7 commits intomainfrom
@lkuchno/test-tabs-layout-direction
Apr 8, 2026
Merged

refactor(tests): reorganizing test-tabs-layout-direction plus scenario#3845
LKuchno merged 7 commits intomainfrom
@lkuchno/test-tabs-layout-direction

Conversation

@LKuchno
Copy link
Copy Markdown
Collaborator

@LKuchno LKuchno commented Apr 7, 2026

Description

Reorganizing test-tabs-layout-direction plus adding scenario

Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1113

Changes

  • test move to separate directory under SFT-> tabs
  • test file renamed to index.tsx
  • no other changes in test file
  • manual sceanrio .md added to the same directory

@LKuchno LKuchno added the area:tabs Issue related to bottom tabs label Apr 7, 2026
Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same remarks as in #3844

Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thank you!

I have one remark. I think we should also introduce this as a general rule applying to all tests 👇🏻

Let me know what do you think.

Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LKuchno LKuchno merged commit 67226c4 into main Apr 8, 2026
3 checks passed
@LKuchno LKuchno deleted the @lkuchno/test-tabs-layout-direction branch April 8, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tabs Issue related to bottom tabs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants