fix: invalidate child SVG nodes on layout change #2722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2671
Previously, the issue was that when the parent ’s width is changed at runtime (via useState or other dynamic styling), the | inside an with width="100%" does not redraw to fill the new width. Instead, it remains at the width it had when first mounted.
This commit adds layout tracking via
_lastBounds
and triggers a recursive invalidation of allRNSVGNode
subviews duringlayoutSubviews
only when the bounds change.Test Plan
You can easily test that solution by running the
Test2671
Compatibility
Checklist
README.md
__tests__
folder