fix: prevent undefined override props from overriding SVG element props #2726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
That PR fixed issue #2693
This change prevents undefined values from being spread into the SVG component props, which could override existing props with undefined values.
expected result:
https://www.svgviewer.dev/s/RCPYq8HE
https://www.svgviewer.dev/s/lUyhreuZ
Test Plan
You can easily test that solution by running Test2693
Compatibility
Checklist
README.md
__tests__
folder