Skip to content

Conversation

bohdanprog
Copy link
Contributor

@bohdanprog bohdanprog commented Jul 31, 2025

Summary

That PR fixed issue #2693

This change prevents undefined values from being spread into the SVG component props, which could override existing props with undefined values.

expected result:
https://www.svgviewer.dev/s/RCPYq8HE
https://www.svgviewer.dev/s/lUyhreuZ

Test Plan

You can easily test that solution by running Test2693

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@bohdanprog
Copy link
Contributor Author

Hey @jakex7, could you take a look at that small PR, thanks ;)

@ClaudiuHBann
Copy link

@bohdanprog on my end it doesn't seem to be fixed, have you tested on windows as well?
image

@bohdanprog
Copy link
Contributor Author

bohdanprog commented Jul 31, 2025

@ClaudiuHBann Unfortunately, I don't have a Windows device. Could you check iOS or Android, please?

@ClaudiuHBann
Copy link

@bohdanprog I just tested on my Android device and it works great, I guess on iOS works as well, but on Windows remains the same, anyway LGTM! 😄

@bohdanprog
Copy link
Contributor Author

@ClaudiuHBann Well, maybe you should recompile the Windows source of SVG? I'm not familiar with Windows :(
But we could try to find a way to solve that on Windows, too.

@bohdanprog
Copy link
Contributor Author

bohdanprog commented Jul 31, 2025

@ClaudiuHBann, please try to apply the patch and check if it solves the problem.
my_custom_patch_file.patch
updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants