feat: replace OnLayoutEvent with SvgOnLayoutEvent #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperzolkiewski
force-pushed
the
removeOnLayoutEvent
branch
from
4e34ac9 to
c7b0311
Compare
kacperzolkiewski
changed the title
kacperzolkiewski
changed the title
kacperzolkiewski
force-pushed
the
removeOnLayoutEvent
branch
from
9541ccb to
89543b6
Compare
|
We'd love to see it merged as |
piaskowyk
reviewed
Sep 8, 2025
Comment on lines
+308
to
+311
| x: Int32; | ||
| y: Int32; | ||
| width: Int32; | ||
| height: Int32; |
There was a problem hiding this comment.
Are you sure it should be Int instead of Float?
There was a problem hiding this comment.
During implementation I was looking at official RN code: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/OnLayoutEvent.kt
And there they have ints
There was a problem hiding this comment.
Also when we look at the creation of SVGOnLayoutEvent inside VirtualView we pass to this event Ints:
https://github.com/software-mansion/react-native-svg/pull/2738/files#diff-b99e5fc93019444c57df66f6135a6ff9c28d881abe126fc0adb12773b24a7193R608
kacperzolkiewski
force-pushed
the
removeOnLayoutEvent
branch
2 times, most recently
from
1996b31 to
62b9d78
Compare
jakex7
approved these changes
Sep 8, 2025
WoLewicki
approved these changes
Sep 8, 2025
piaskowyk
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates
SvgOnLayoutEventand replaces usage ofOnLayoutEventfor Android because React Native Android team will remove this event from their codebase in near future.Test Plan
Verified that the onLayout event emitted by Svg produces the same payload before and after this change.
Steps:
Result:
Event payload structure and values remained identical
Compatibility
Checklist