Skip to content

Conversation

kacperzolkiewski
Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski commented Aug 20, 2025

Summary

This PR fixes: #2746

  • Previously, the strokeMiterlimit prop had no effect on iOS because it wasn’t being applied to the drawing context.
  • Applied strokeMiterlimit correctly by calling CGContextSetMiterLimit.
  • Ensures the prop now works as expected when using strokeLinejoin="miter".
  • Structured default behavior on all architectures so that when strokeMiterlimit is not specified, it falls back to 4.0 (matching old arch implementation).

Test Plan

  1. Run the example from issue Strange spike on number 2 with stroke on iOS #2746.
  2. Add the strokeMiterlimit prop to (e.g. strokeMiterlimit={2}).
  3. Verify that the number 2 renders without spikes when using strokeLinejoin="miter" (miter is strokeLinejoin default value).
  4. Remove the prop and confirm the default value is applied (strokeMiterlimit=4).
  5. Test also with strokeLinejoin="round" and "bevel" to confirm consistent behavior.

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a simulator

@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review August 21, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange spike on number 2 with stroke on iOS

1 participant