Skip to content

Conversation

kacperzolkiewski
Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski commented Aug 27, 2025

Summary

This PR fixes: #2475

  • add support for verticalAlign prop
  • remove native code from Android that incorrectly managed setting verticalAlign
  • add verticalAlign.pegjs file for parsing verticalAlign into alignmentBaseline and baselineShift
  • reuses the existing native support for alignmentBaseline and baselineShift by passing the parsed values through
  • remove verticalAlign prop from codegen schemas

Test Plan

Run Test2475 and check if verticalAlign property works.

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator

@kacperzolkiewski kacperzolkiewski changed the title fix: add pegjs for parsing verticalAlign into alignmentBaseline and b… fix: parse verticalAlign into alignmentBaseline and baselineShift Aug 27, 2025
@kacperzolkiewski kacperzolkiewski changed the title fix: parse verticalAlign into alignmentBaseline and baselineShift fix: add support for 'verticalAlign' prop Aug 28, 2025
@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review August 28, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verticalAlign Prop of SVG Text Component Not Working

1 participant